theme_gallery_assist_display() expected to be a reference, value given (Php 5.3.0)

Hello vase,

I had not replied to you earlier because I wanted to investigate how important the issues "variable referencing. I use it no more and so the problem is solved

Please download the new version (6.x-1.7) at drupal.org and report me or I can close this issue.

Regards and thanks
Juan Carlos

I close this report.
In the new versions is this fixed because I not use more the reference for own variables on themes functions.

In case of use this version the "&" should be removed by each function with name begin "theme_xxx".

When not correct please. Tell me the right way.

Regards
Juan Carlos

Hello,

I installed a brand new drupal installation. Just added the image assist module. When creating a first gallery (the only content on the site) I got this warning message again.

Drupal version: 6-14
Image asssit version: 6x-1.8 beta2

any ideas?

I already tried to delete all '&' as described above

Kind regards

Tom

Still happen on xampp 1.7.2 running on windows.

I am a newbie here. I am working on my localhost & I am having the same issue.

warning: Parameter 1 to theme_gallery_assist_display() expected to be a reference, value given in C:\wamp\www\A&W_Construction Project\includes\theme.inc on line 617.

I am able to add the pictures, but when I try to see it, this is the error I get.

Please help.!

Hi Juan,
Am trying with 6.1.14 drupal and am getting the above warning.Is this issue still open? Can u help me on this.

Hello,

this is a jump help please go to the line from the error and remove the & from the fucntion.

example:

function theme_the_name_of_the_function(&$variable_name).

Some PHP versions give a error by referenced variables.

Regards
Juan Carlos

PD
Please give me fedback.

Dear Juan,

unfortunately didin't work...

I did modifications in file gallery_assist_list_display.inc:

function theme_gallery_assist_display_list($pager, $boxes, $conf, $type = 'gallery_assist') {

Help us!!! ;-)

Hello

It bothers me when the reports have nothing to do with the module.

The same problems having other modules with several themes.

This here is a PHP issue.

I have tested the case in a wamp, in a xamp and in a easyphp installation. In all the same issue.

Then I have installed the PHP 5.2.9 in the 3 cases and the issue is disappearing. Why? I dont know.

i know only one. This issue is not a bug from Gallery Assist. it is not a bug from Views and from Ubercard etc etc and the othes modules wich use several templates. It is (my opinion) a currently incompatibility.

I have tried to delete some &s as suggested above and I got rid of those errors.
Although I don't really understand PHP, it seems to me that some syntax errors are not tolerated any more since PHP 5.3, so this probably is a 'gallery assist' bug.
Something like a patch follows:

--- gallery_assist_display.inc 2009-12-19 21:42:18.103656898 +0100
+++ gallery_assist_display.inc 2009-12-19 21:42:26.972599411 +0100
@@ -383,11 +383,11 @@
}

/**
* Theme the item output.
*/
-function theme_gallery_assist_display(&$pager, &$boxes, $conf, $type = 'gallery_assist') {
+function theme_gallery_assist_display($pager, $boxes, $conf, $type = 'gallery_assist') {

$output = '

Big THX to bubla...patch works great(even on php 5.3 and xampp 1.7.2) !!!

Hello,

in this case bubla, every time if php have a new version and functions or methods are not more supported, at this moment are the functions or methods "bugs".The use of references was a time a go normal.

Equal you have contributed a solution and all are happy.

In once you give me a lesson. NO SURRENDER!!!

I thankyou very much.

I will update the HEAD with this and other bug fixes.

A lot of thanks
Juan Carlos

Super. I am glad that it works for all of you too.

Juan,

I did remove the & inthe funbction & it works Thank you!

hello,

I got the same problem, and removing the & in the function, doesn't solve the problem. I'm not fancy with php and such. How can I use this patch you gave us bubla?

Thx in advance

Here is full patch for 6.x-1.8.
apoc1:
to apply patch follow this generic instructions http://drupal.org/patch/apply

Hello.
I use Drupal 6.15 running on xammp with PHP 5.3.1. Got she same bugs as described above, then I carefully applied recent patch to gallery assist files. However, no effect -- I still have "Parameter 1 to theme_gallery_assist_display() expected to be a reference, value given in file D:\xampp\htdocs\includes\theme.inc at line 617" at dblog.

I tried to revise all GA files for &'s --- no effect.

The same effect with jquery form update, with or without Imagecache... please, advice, what should I do? This shredbug makes me crazy.

i am also having these problems...i applied the most recent patch but the images are still not showing up in the gallery assist node and i am getting that error in my reports...

Parameter 1 to theme_gallery_assist_display() expected to be a reference, value given in /home/travis/public_html/includes/theme.inc on line 617.

i did apply a patch to imageapi at http://drupal.org/node/540486#comment-2356560 and that solved my other image problems...the thumbs show up in the gallery edit page but nothing in the actual node...i have php 5.3.1

thanks so much for any help

Hmm... I've disabled GA Lighboxes and everythin' gone ok

I disabled the GA Lightboxes module also but nothing changed...still getting the same error and the images aren't showing up.

Hello dhtml2 and treebykooba,

can you let me know, which versions from Gallery Assist and Gallery Assist Lightboxes?

I think it is not a code bug. It is a compatiblility bug. To solve it a have to reconstruct the same enviroment and reproduce the same issue.

Now I know xammp with PHP 5.3.1.
Is mysql version not important?

hello jcmc,

thanks so much for your dedication! it's much appreciated!

my mysql (if it matters) is 5.0.87-community.
my ga lightbox WAS the latest one, 1.2
gallery assist version is 1.8 which i patched, but it didn't work

however......i just updated my ga lightbox to 1.3rc1 and now the thumbs are showing up!!! when i upload a new image that also shows up however most of the images do not show up when clicked on the thumbs...only a few. any ideas on this?
i am so relieved that there's progress being made here, though!!

mil gracias!!!

this is the web page i'm working on if you want to see: http://travis.www51.a2hosting.com
to see your module click on "bright rain artists" and select an artist..i use it for each artist.

it's a great module!

Hello treebykooba,

Go please to the site:

http://pruebas.puntolatinoclub.de

login with the following account data
user: treebykooba
pass: testuser72

Change for the first your password and let me know it here.
I put you to the admint.

I've investigated a little your html source and saw some things that better we discuse in a practice area.

Thanks and Regards

I applied patch manually. Worked just fine for me.
Thank you!

The patch didn't work for me.

Someone has another solution ?

If you use both modules:
gallery_assist
gallery_assist_lightboxes

you need to apply patch for both modules. Otherwise some functionality will be still broken if you apply it only for the first module.

IMPORTANT: You cannot apply patch automatically for the secod module since it was build for the first one. So, you must open the patch and change files manually.

Please people,

Specify better your issue. A lot of people are using the module and not have the same problem as you.
Unfortunately I don't have the knowledge or maybe the needed rights to publish other new releases to the project page so that the system recomend a old version as stable.
Better review the list of all releases.

many thanks to almalino for the little help by support

Regards
Juan Carlos

fixed. See http://travis.www51.a2hosting.com. Gallery Assist works.